Skip to content

fix(linalg): Validate eps values in QuadprogProjector constructor #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValerianRey merged 2 commits into from
Oct 7, 2026
Merged

fix(linalg): Validate eps values in QuadprogProjector constructor #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e07b7
fix(linalg): Validate eps values in QuadprogProjector constructor
SausageMan99 Oct 7, 2026
9f8e534
Merge branch 'main' into fix/810-quadprog-eps-validation
ValerianRey Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/torchjd/_linalg/_dual_cone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ def __init__(
reg_eps: float = 0.0001,
) -> None:
super().__init__()
self._norm_eps = norm_eps
self._reg_eps = reg_eps
self.norm_eps = norm_eps
self.reg_eps = reg_eps

@property
def norm_eps(self) -> float:
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/linalg/test_dual_cone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,16 @@ def test_reg_eps_setter_rejects_negative() -> None:
projector.reg_eps = -1e-9


def test_init_rejects_negative_norm_eps() -> None:
with raises(ValueError, match="norm_eps"):
QuadprogProjector(norm_eps=-1e-9)


def test_init_rejects_negative_reg_eps() -> None:
with raises(ValueError, match="reg_eps"):
QuadprogProjector(reg_eps=-1e-9)


def test_qp_solver_based_failure() -> None:
"""
Tests that `QPSolverBased._project_weight_vector` raises an error when the input G has too large
Expand Down
Loading