Repository navigation
Conversation
ValerianRey
reviewed
Oct 9, 2026
ValerianRey
left a comment
ValerianRey
left a comment
Member
There was a problem hiding this comment.
Shouldn't the helper mappings stay in mappins.rs? Seems weird to have them in the new file.
Collaborator
Author
|
@ValerianRey Sure i pushed the changes |
ValerianRey
approved these changes
Oct 9, 2026
Member
|
lgtm thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8: moves
Signature,HRectSignatureand theHRectMapping/HRectPowersetMappinghelper traits with their blanket impls frommapping.rsinto a newsignature.rs.The code is moved unchanged, and
SignatureandHRectSignatureare still re-exported fromlib.rs.Also escapes
[N]in theInvProjectiondoc comment, which rustdoc read as a broken link and madecargo docfail.