Skip to content

Address the missing features from the current sharing pane. - #896

Draft
SharonStrats wants to merge 11 commits into
stagingfrom
feat/acl-match-legacy
Draft

SharonStrats wants to merge 11 commits into
stagingfrom
feat/acl-match-legacy

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

There were a few things I found that were missing from the new design this is my attempt to implement them. It's a bit rough, but didn't want to spend too much time wanted to get feedback first.

Here are the missing items that are in our current sharing pane:

  1. For all resources the user can reset the sharing back to the default which would remove it's specific access settings.
  2. Containers have 3 different "types" of access Folder+Contents, FolderOnly and ContentsOnly.
  3. Trusted Apps in your profile show up in the list of options that you can select. (I am wondering if this is needed, because I haven't seen the screen anymore where you grant trusted apps)
  4. This one is not done yet: there is also another Role that we need to add which is Owner (write locked) I was thinking we should add another role, but I am not sure what to call it yet.

At the top it says what "type" of access you are looking at, the default is "Folder and Contents", but it is driven by the access that is already granted by the container. So if a container only has accessTo without the default it will show "Content Only" and so forth. And below if you click on advanced this changes so that you can set sharing for the different types, one at a time.

Another idea is we should list all 3 options at the top to click through and each change triggers the share with area to change... I just thought of this now would not be hard to change

Note: Also, if a container has multiple "types" in it's acl then it will show a red message at the top that says it has "advanced" sharing.. so the user knows they need to select advanced to see all the access for the container.

Default for the top section:
Screenshot 2026-10-18 at 9 53 38 PM

Main view:
Screenshot 2026-10-18 at 9 46 56 PM

Here is where you can toggle the access types, when you click on the Advanced button above otherwise it doesn't show:
Screenshot 2026-10-18 at 9 47 45 PM

Here is the view where you can reset to default if a resource has specific sharing:
Screenshot 2026-10-18 at 9 48 38 PM

SharonStrats and others added 7 commits October 16, 2026 22:29
Prompt: Fix stale async header/menu updates using a generation counter.

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
… solid-panes and folder-pane

Prompt: Move the getRelevantPane function to solid-ui from solid-panes

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
…t can be used in solid-panes and the folder-pane

Prompt: Create a compose explorer function that can be used in solid-panes and folder-pane so that we can centralize the file explorer composition.

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats and others added 2 commits October 19, 2026 15:19
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SharonStrats
SharonStrats force-pushed the feat/acl-match-legacy branch from 330be65 to 98e53f8 Compare October 19, 2026 04:32
@timea-solid

timea-solid commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

I have a few feedback thoughts:

  • the dialog is crowded now and it contains a lot of elements which are not intuitive. As a general rule I would prefer a simple UI with less options and hide everything else under Advanced.
    I would remove the 2 extra info blocks:
677133017-b13d0216-7553-469e-aa37-3ea684f299fb

@timea-solid

timea-solid commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

The change in access inside the container is confusing. I would rather leave it out for now completely.
I want the acces dialogue to work like a google drive access. If I give access to a folder to somoene in drive I, as a user expect that the person will have the same access level to all its content. This is what I want to see here too by default without further overwhelming the user with options of contents only, folder only, both...

'At the top it says what "type" of access you are looking at, the default is "Folder and Contents", but it is driven by the access that is already granted by the container. So if a container only has accessTo without the default it will show "Content Only" and so forth. And below if you click on advanced this changes so that you can set sharing for the different types, one at a time.'
I would simply not add this anywhere as a tag...

@timea-solid

Copy link
Copy Markdown
Member

'Default' access is a piece of information a regular user cannot do anything with. What does default mean? How to explain it? I believe it is useless to have that tag.
Instead: when I open the access to any resource, I would like the default to be reflected in the list of people/apps that hav access to this resource and in which way.

@timea-solid

Copy link
Copy Markdown
Member

Reset to default action - again, i think it has no use to the user if they do not know what default means. I would maybe take that out.

@timea-solid

Copy link
Copy Markdown
Member

Trusted Apps is under Prefferences but that is a different matter i believe.

@timea-solid

Copy link
Copy Markdown
Member

Owner (write locked) means for me that I as owner have only the View access. But it also means I as Owner cannot modify it. or?
So I would simply have the the list of people my name and viewer and that is it. Lets see if the users give us any feedback on it later... if they get it or not.

@timea-solid

Copy link
Copy Markdown
Member

After al this, I am not sure what the advanced part will contain. MAybe we simply leave it out for now. The code we can keep.

@timea-solid

timea-solid commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

I would also make some work changes, even if it is not 100% like in the design:

  • I would call the overall dialog: Manage access of 'name of resource'
  • and the list header 'Shared with'
  • Under General access i would name the 2 options: Anyone with the link and Only logged in users with the link. (in any case keep the wording logged in, as the Log In button)

@SharonStrats

Copy link
Copy Markdown
Collaborator Author

'Default' access is a piece of information a regular user cannot do anything with. What does default mean? How to explain it? I believe it is useless to have that tag. Instead: when I open the access to any resource, I would like the default to be reflected in the list of people/apps that hav access to this resource and in which way.

Yes that is how it's working, all the access is shown in the share with area, when it has no specific acl it is the access rules that it has inherited.

@SharonStrats

Copy link
Copy Markdown
Collaborator Author

Trusted Apps is under Prefferences but that is a different matter i believe.

I think I will leave this in all it does is if a user has TrustedApps it will list them in the search so they can be selected. There isn't any behavior change or anything.

@SharonStrats

Copy link
Copy Markdown
Collaborator Author

Owner (write locked) means for me that I as owner have only the View access. But it also means I as Owner cannot modify it. or? So I would simply have the the list of people my name and viewer and that is it. Lets see if the users give us any feedback on it later... if they get it or not.

Because they have control they can view it like you mentioned, but they can also control the sharing so they can grant access to the resource. But yes that is correct they can not write or append to the document or container.

@SharonStrats

Copy link
Copy Markdown
Collaborator Author

After al this, I am not sure what the advanced part will contain. MAybe we simply leave it out for now. The code we can keep.

I think I will change the Advanced area to contain the reset and the other stuff, but see if I can simplify and then i can hide it for now. I won't spend too much time on it though, will mainly focus on fixing bugs for release.

Prompt: multiple prompts to work to see what is possible to make sure not to lose functionality will review it after we have a look and improve code and design.

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SharonStrats
SharonStrats force-pushed the feat/acl-match-legacy branch from 539e6fa to 0a81f51 Compare October 19, 2026 12:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants