Repository navigation
attachmentList changes - #897
Conversation
…istry@5.0.2-0) (latest: rdflib@2.4.1)
There was a problem hiding this comment.
🟡 Changes recommended
Closing externally focused confirmations needs focus restoration so users retain their position in the list.
1 open issue
What changed in this PR
Adds configurable placement for attachment deletion confirmations while preserving default row-local behavior.
Changes:
- Threads the optional confirmation container through widget helpers.
- Replaces default navigation images with Lucide icons.
- Adds combobox focus styling, documentation, and regression tests.
| File | Description |
|---|---|
| test/unit/widgets/buttons/iconLink.test.ts | Tests Lucide rendering and custom icons. |
| test/unit/widgets/buttons.test.ts | Tests confirmation placement and handlers. |
| src/widgets/buttons/iconLinks.ts | Uses Lucide navigation icons by default. |
| src/widgets/buttons.ts | Supports external confirmation containers. |
| src/components/combobox/Combobox.styles.css | Adds visible keyboard focus styling. |
| README.md | Documents icons and confirmation options. |
Review effort: Balanced
| padding-right: 40px; | ||
| width: 100%; | ||
|
|
||
| /* Global focus styles don't reach into the shadow DOM, so mirror them here. */ |
There was a problem hiding this comment.
I don't think these are the way we should do the styles anymore I might be wrong but I think this is the way we did them in mashlib but now everything is in themes.css
so for instance i think they should be
outline: 2px solid var(--solid-ui-color-primary, #7C4DFF). (only --focus-indicator-width and this --color-primary if you wanted style configuration from the caller, and with that you should add them at the top under :host if you want to do that.
for
box-shadow: 0 0 0 1px #F8F9FB, 0 0 0 4px rgba(124, 77, 255, 0.2); maybe just that for now, otherwise you can also add to themes.css a solid-ui-color-{color}-{level} for this color.
There was a problem hiding this comment.
I think we need a bigger style redo in most panes. Later.
SharonStrats
left a comment
SharonStrats
left a comment
There was a problem hiding this comment.
I just had the one comment about the styles in combobox, but everything else looks great!
This is improving the attachmentLidt function by adding an optional parameter (it does not chnage the API) which determines in which container/div teh delete pop up appears.
This PR also changes the go-to-icon to a new lucide icon. The side effect is that in the file explorer the icon will look like:
This is how it looks on the friends list now too.