Repository navigation
fix(plugins): wait for the network before the plugin update pass - #3519
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#3507 deleted the
NWPathMonitorwithout the fetch the plan put in its place (step 22). Offline at launch, the plugin update pass gave up after five tries, and reconnecting did not start it again.Change
waitsForConnectivityand a 7-day resource timeout, so offline it waits for the network instead of spending tries.Verified
connectionSkipsThePassWaitingForTheNetwork()fails when the pass joins the interactive fetch or holds connections during its fetch.RegistryClientFreshnessTestschanged becausefetch(policy:)now returns the manifest.