Repository navigation
feat(banner): always show the license banner, on a brand-hue tint - #124
Merged
Merged
Conversation
The banner can no longer be closed: the dismiss button, the "Have a license?" link, the stored record (`tablepro:banner-dismissed`), its version and the head script that read it are gone, so every reader sees it on every page it belongs on. The one browser-side rule left is /ios for a reader on an iPhone or iPad, whose app has no license. Its ground is a left-to-right wash of the brand hue over the page colour (14% to 6% of --accent, mixed in oklab so the neutrals' hue 0 does not pull it towards red, under a rule in the same hue), within the design system's text contrast pairs in both themes. The privacy policy no longer lists the storage key, in every language, and its date moves to 2026-10-22. Config, the shared prop, the catalogs, analytics (no dismiss event, no version parameter), docs and tests follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/banner.ts, thetablepro:banner-dismissedrecord,banner.versionand the head script that read the record are removed. Every reader sees the band on every page it belongs on. The only browser-side rule left is/iosfor a reader on an iPhone or iPad.color-mix(in oklab, --accent 14% → 6%, --background)under a rule of--accent30% in--rule(app.css). A tint, not a fill:--foregroundtext and the--accent-textlink measure 17.5:1 / 5.1:1 on the strongest stop in light and 14.5:1 / 8.2:1 in dark, within the design system's pairs. Mixed in oklab on purpose: the neutral tokens write hue 0, and an oklch mix came out pink. Forced colours drop the gradient.updatedAtmoves to 2026-10-22.controls.dismissandbanner.licensedleave the catalogs. Analytics keepslicense_banner_view/license_banner_clickwithout parameters and loseslicense_banner_dismiss. Docs (architecture.md, design-system §5.3.17, sitemap, rebuild tables) follow.Test plan
vendor/bin/pint --dirty,npm run typecheck,npm run test:js(280 pass)TopBannerTestrewritten: "cannot be closed" and the tint are pinned;LegalPagesTest,PublicContractsTest,SiteChromeTest,device.test.tsupdatedPageChunkTeststale manifest,IntegrationsDataTestmissingopis/json-schema), unrelatedFollow-ups
tablepro:banner-dismissed(companion PR).versionstops receiving data and can be archived..env: aBANNER_VERSIONline, if present, is now ignored and can be deleted.🤖 Generated with Claude Code