Repository navigation
Conversation
…ports TypeScript probes `directoryExists` with paths that are files during module resolution; `Tree.getDir()` throws on those. Report them as non-directories. Fixes TanStack#12032 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 1e3270d
☁️ Nx Cloud last updated this comment at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fixes #12032.
migrate-from-experimentalaborts before migrating anything when a project source imports a package subpath that names a file, for exampleimport { sha3_256 } from '@noble/hashes/sha3.js':TypeScript's module resolution calls the compiler host's
directoryExistswith candidate paths, and some of them are files. The host inconfiguredSources()passed every path totree.getDir(), which throwsPathIsFileExceptionfor a file.directoryExistsnow returnsfalsewhen the path is a file (tree.exists()is true only for files).The new regression test in
migrate-from-experimental.test.tsbuilds a workspace whose source imports a file subpath of a package with anexportsmap. It fails without the fix, with the error above, and passes with it. Repro: https://github.com/imaksp/tanstack-angular-query-migrate-schematic-repro✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.test:pr. Inpackages/angular-queryI ran the schematic suite (vitest.schematics.config.ts, 71/71),test:eslintandtest:types:tscurrent.🚀 Release Impact
🤖 Generated with Claude Code