Skip to content

fix(maths): validate input parameters and add doctests for harmonic p… #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdas-19 wants to merge 1 commit into from
Closed

fix(maths): validate input parameters and add doctests for harmonic p… #15580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions maths/sum_of_harmonic_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,19 @@ def sum_of_harmonic_progression(
0.75
>>> sum_of_harmonic_progression(1 / 5, 5, 5)
0.45666666666666667
>>> sum_of_harmonic_progression(0,2,5)
Traceback (most recent call last):
...
ValueError: first_term cannot be zero
>>> sum_of_harmonic_progression(1/2,2,0)
Traceback (most recent call last):
...
ValueError: number_of_terms must be greater than zero
"""
if first_term == 0:
raise ValueError("first_term cannot be zero")
if number_of_terms <= 0:
raise ValueError("number_of_terms must be greater than zero")
arithmetic_progression = [1 / first_term]
first_term = 1 / first_term
for _ in range(number_of_terms - 1):
Expand Down
Loading