Skip to content

Face-to-face: avatars and room title differ per home (regressions of #137/#172); Leave is abrupt and not seen by the peer #182

Closed

Description

@Birfy

Environment

ThinkFlowLab/FlyBot main c3bb44f (after #176, #177; core, plugins/social, plugins/tree) on @deepseek-ai/dsh@0.2.0-rc.2, Node 24. Two fresh installs on one Linux box: A :3080 (owner SelfA1933, @selfa1933.home, Bots Chief + Helper), B :3081 (SelfB1933, @selfb1933.home, Chief). Bot Social https://47-80-69-220.sslip.io. Scheduled product self-test, 2026-10-17 19:38–19:44 Asia/Shanghai. No model key on the box (model errors are not the bug).

Repro

A and B join face room 482913 with Chief each, Enter chat, chat a little, then B clicks Leave.

Actual

Expected

  • Every member sees each Bot's own avatar and the same room title and time on every home.
  • Room details have one clear row of actions. The Auto-send label names the pair (e.g. "Auto-send Chief → room").
  • Leave asks for confirmation (or offers undo) and goes straight to a sensible view without a blank pane. The other side sees the leave within the normal poll time, without a reload.

Activity

  1. Birfy commented on Oct 17, 2026

    @Birfy
    CollaboratorAuthor

    Merged on main (c56384a): #186 covers part of this issue.

    Covered (#186)

    • Leave on a live room asks once (Leave / Stay), then opens the main Bot (no blank pane).
    • Peer leave sticks: a room left/closed is no longer flipped back to open by a later poll; the other side sees the leave within one poll.
    • Same room title and start time on every home (title built from every member the room has had, uses start time, not the joining deadline).
    • Auto-send checkbox names the Bot (Auto-send Chief → room).

    Skipped (leaving this open)

    • Orange peer-avatar blob: not diagnosed, could not reproduce from code, needs a live repro.
    • Waiting state for other members: needs a Bot Social server signal.
    • Footer turn/step counter: native to DSH, not changed here.
    • Room-details row layout beyond the label.
  2. Birfy commented on Oct 17, 2026

    @Birfy
    CollaboratorAuthor

    Self-test on 38c00b4:

  3. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Status against main 7a3ccb3 (2026-10-18 ~10:30 Asia/Shanghai):

    Done

    Still open (why this issue stays open)

    Out of scope here: the footer turn/step counter, which comes from DSH.

  4. Birfy commented on Oct 18, 2026

    @Birfy
    CollaboratorAuthor

    Self-test on a003044 (2026-10-18 16:27–16:33 Asia/Shanghai, fresh A :3090 / B :3091, focus: Face-to-face room):

  5. added
    bugSomething isn't working
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    self-testFiled by the product self-test routine (issues only)
    needs-infoWaiting for the reporter or a maintainer decision
    on Oct 19, 2026
  6. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Triage on main 7b9e90b, 2026-10-19 ~12:10 Asia/Shanghai: still open, needs-info. The cross-home look part was worked on in #377 (a Bot's new Bot Social identity gets its look again). Whether a Bot now looks the same on both homes (tiles, members, sidebar, bubbles) and inside one home (waiting dialog vs details) has not been re-checked since. Blocking question: does the avatar/colour mismatch still reproduce on current main? Next self-test of face-to-face rooms should check and note what is still different. The "waiting state for other members" part needs a Bot Social server signal (separate issue in Birfy/bot-social if still wanted).

  7. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Triage on main 0852b3f, 2026-10-19 16:59 Asia/Shanghai: still needs-info. No face-to-face self-test has run since #377, which re-sends a Bot's look to each new room-only identity.

    Owner-delegated decision: "waiting state for other members" leaves this issue. It needs a Bot Social server signal. If it is still wanted, it goes in its own Birfy/bot-social issue. The footer counter is DSH's and also out of scope. What remains here is only the Bot look.

    Repro for the next face-to-face self-test (fresh A/B): give A's Chief a non-default look (e.g. cat, green) before joining. A and B join one room with Chief each. On both homes, compare each Chief's avatar and colour in:

    • the waiting dialog,
    • the room tiles,
    • the details member list,
    • the sidebar row,
    • the reply bubbles.
      Then leave, start a second room (new room-only identity) and compare again. Close this issue if every place matches the owner's look. Otherwise note which place differs, on which home.
  8. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Maintenance triage (2026-10-19 20:01 Asia/Shanghai, main 753b7e9): still needs-info. No new live self-test since the 16:59 check. Leaving open; next face/friend self-test should run the repro notes on the previous comment. Not pushing design questions while this waits on live confirmation.

  9. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Self-test 2026-10-20 ~01:00 Asia/Shanghai still sees this at main 84a95a6 (homes SelfA0056 / SelfB0056, room 482915):

    • In A's waiting dialog A's Chief is a purple acorn, but on A's sidebar and on B it is a blue whale.
    • In A's room chat B's Chief is a teal blob, but in A's Members panel it is a blue whale.
    • On B, A's Chief and B's own Chief are identical blue whales (can't tell them apart).
    • People get a generic grey silhouette everywhere (own bubbles have no avatar at all).
      Expected: one avatar per Bot, taken from its owner's profile and identical in waiting tiles, chat, Members and sidebar on both homes; two different Bots never render identically; people show their own avatar/initial.
  10. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Maintenance triage (2026-10-20 01:58 Asia/Shanghai, main 84a95a6): reproduced live by the 01:00 self-test, moving from needs-info to needs-human. Proposed: one avatar per Bot, taken from its owner's Bot Social profile (the owner home's own choice) and used identically in waiting tiles, chat, Members and sidebar on both homes; a deterministic per-handle fallback so two different Bots never render identically; people get their profile avatar (or an initials avatar) everywhere, including own bubbles. If the server profile lacks an avatar field, a small Bot Social issue would be filed (needs the owner's yes before any prod deploy). Waiting on the owner's yes to apply agent-ready.

  11. added
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    and removed
    needs-infoWaiting for the reporter or a maintainer decision
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 19, 2026
  12. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (2026-10-20): Confirmed as proposed: avatars come consistently from the owner's Bot Social profile everywhere, with non-colliding fallbacks. If the server needs an avatar field, file a separate Bot Social issue; production deploy still needs the owner's explicit yes.

  13. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 19, 2026
  14. self-assigned this
    on Oct 19, 2026
  15. Birfy commented on Oct 19, 2026

    @Birfy
    CollaboratorAuthor

    Claimed by maintenance (2026-10-20 07:58 Asia/Shanghai). Working on branch fix/182-face-room-avatars-title in Birfy/FlyBot, developed in parallel with the other face-room issues (#462, #458, #457, #455, #304, #182); they will merge one after another.

  16. Birfy commented on Oct 20, 2026

    @Birfy
    CollaboratorAuthor

    Minor decisions for PR #464 (2026-10-20 08:10 Asia/Shanghai), following the Owner decision:

  17. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copybugSomething isn't workingself-testFiled by the product self-test routine (issues only)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions