Skip to content

Host/core messages and zh strings still say 'Bot settings → Invite to this Bot' after #504 #506

Closed

Description

@Birfy

Owner decision: approved (Danyang Chen, 2026-10-20 14:30 Asia/Shanghai).

Problem

#504 (still open at filing) renames the Sharing button to Copy invite link for and updates README / docs / plugins/social/client.js, but host/core messages and zh strings still tell the user to use Bot settings → Invite to this Bot. Once #504 lands these point at a button that no longer exists. (Do after / on top of #504.)

Affected spots (git grep "Invite to this Bot" on main b1ab6e4, excluding files #504 already changes)

User-visible (must change):

  • core/src/host/room-membership.js:485 — ungranted-local refusal: Share … with ${friends} (Bot settings → Invite to this Bot), or leave … out.
  • patches/ds-bot/files/src/host/room-membership.js:485 — same (patch copy; regenerate the corresponding patch)
  • core/src/client/i18n.js:87 — 'Could not create the invite. Use Bot settings → Invite to this Bot.' + zh 请在 Bot 设置里使用 Invite to this Bot。
  • core/src/client/new-chat.js:77 — setFixNote(t('Could not create the invite. Use Bot settings → Invite to this Bot.'))
  • core/client.js:124, 10427 — bundled copy of the above (rebuild)
  • patches/ds-bot/0001-core-fixes.patch:309 — i18n key + zh string
  • patches/ds-bot/0003-flybot-api-client.patch:1214 — new-chat.js setFixNote
  • patches/ds-bot/0008-client-bundle.patch:67, 8221 — bundle copies
  • Tests: core/test/remote-room.test.js:919, patches/ds-bot/files/test/remote-room.test.js:919 (/Invite to this Bot/)

Comments / docs (update for consistency):

  • core/src/host/hooks.js:936, core/src/host/reach.js:10, core/types/flybot.d.ts:34 (+ patches/ds-bot/files/... copies)
  • plugins/social/src/social.js:10, plugins/social/README.md:21, plugins/tree/README.md:17, plugins/tree/src/adapter.js:13, plugins/tree/src/middleware.js:10
  • docs/subsystems/social.md:13, 48, docs/subsystems/team.md:75

Fix

Point messages at Sharing → Copy invite link for (e.g. Share it with ${friends} (Bot settings → Sharing → Copy invite link for ${name})), with matching zh strings (keep the i18n key and string in sync across core, bundle and patches). Update the tests' regex. After the change, git grep "Invite to this Bot" should return nothing outside changelog history.

Activity

  1. added
    bugSomething isn't working
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 20, 2026
  2. self-assigned this
    on Oct 20, 2026
  3. Birfy commented on Oct 20, 2026

    @Birfy
    CollaboratorAuthor

    Claimed 2026-10-20 14:55 Asia/Shanghai for development on branch fix/506-invite-copy-leftovers (may stack on #504 / fix/499-invite-friendchat-polish).

  4. Birfy commented on Oct 20, 2026

    @Birfy
    CollaboratorAuthor

    Opened #515 (fix/506-invite-copy-leftovers, tip 6e7e9e6f1a24b49008d1daf201b13f2ae62be8f9).

    Based on #504 (fix/499-invite-friendchat-polish) + merged origin/main. User-visible leftovers now say Bot settings → Sharing → Copy invite link (host refusal, i18n/zh, new-chat fix note); docs/comments/tests updated; patches regenerated. ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify passed locally.

    Minor decisions: singular/plural refusal uses the already-joined Bot names in the Copy invite link path; zh keeps the English button name in the Sharing path (same pattern as before).

  5. added
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    on Oct 20, 2026
  6. added a commit that references this issue on Oct 20, 2026
    4537462
  7. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copybugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions