Repository navigation
Make the connectors test cleanup stable (ENOTEMPTY flake) #532
Description
What
core/test/connectors.test.js flakes: a test's temp home is still written by a background save that outlives dispose(), so rmSync in the cleanup hook sometimes fails with ENOTEMPTY: directory not empty. It fails a whole npm run verify / CI run at random (seen repeatedly today).
Expected behavior
- The cleanup settles and retries; if it is still racing, it leaves the temp dir rather than failing the run. The test's own assertions have already passed by then.
Change scope
core/test/connectors.test.js (a cleanHome helper replacing the raw rmSync cleanups). Test only; no product behavior.
Why
Reliability: a flaky cleanup wastes a full CI run and can block a green PR at random (it has blocked my own verify evidence several times today).
Activity
Birfy commentedon Oct 20, 2026
Triage (Birfy, 2026-10-20 20:08 Asia/Shanghai). Test-stability fix only:
core/test/connectors.test.jscleanup sometimes hits ENOTEMPTY because a background save outlivesdispose(). The fix is acleanHome()helper that settles, retries, and otherwise leaves the temp dir. No product behavior and no owner design rule involved, so it is process/hygiene and needs no product decision.HugoXK's PR #533 implements it. Reviewed PASS at e4d3c7f, risk:T1, CI green. It is held only because it touches
patches/ds-bot/0001-core-fixes.patch, which awaiting-approval PRs #515/#494/#493 also change. It will merge after those land, and that merge closes this issue. Follow-up note: if a save afterdispose()ever shows up outside tests, that's a separate host bug.Birfy commentedon Oct 20, 2026
Owner decision (Danyang Chen, 2026-10-20 21:09 Asia/Shanghai): option (a), accept PR #533 as is (test-only, T1). It is queued only after #515 lands (#493 was closed, so #515 is the only thing it waits for). Labeled
agent-readyper that decision; #533 is the implementation, so no separate development.Birfy commentedon Oct 21, 2026
Triage: the implementation PR #533 is open but stale — its head has not moved since 2026-10-20 15:06 (
e4d3c7f6), it now conflicts withmain, and the author has not replied.The bug itself is still valid (the connectors test cleanup is an ENOTEMPTY flake). Either the author merges
maininto the branch and pushes, or a maintenance round recaptures the fix on a fresh branch; until then this staysagent-workingand is not merged.Birfy commentedon Oct 21, 2026
Recaptured by the maintenance round on a fresh branch
fix/532-connectors-cleanupfrommain(105ec65b); PR #533 had not moved since 2026-10-20 15:06 and conflicts withmain, so it is closed as superseded.The fix is the same idea plus a test that pins the contract: every cleanup goes through
cleanHome, which retries a racing save and leaves the temp dir when it never settles. Test-only, T1.Make the connectors test cleanup stable (ENOTEMPTY flake) (ThinkFlowL…