Skip to content

Route a friend's plain face-room line like the owner's: routed, single pass, no follow-ups - #465

Merged
Birfy merged 1 commit into
ThinkFlowLab:mainfrom
Birfy:fix/462-friend-line-face-routing
Oct 20, 2026
Merged

Birfy merged 1 commit into
ThinkFlowLab:mainfrom
Birfy:fix/462-friend-line-face-routing

Conversation

@Birfy

@Birfy Birfy commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Fixes #462

What: A friend's attested plain line in a face-to-face room now goes through the same routing (#299) and single-pass no-follow-up rule (#295) as the owner's own line (owner decision 2026-10-20).

Why: postHuman posts the friend's line from the quiet face-notice sender, so it reached the round with botId: 'face-notice'. isPlainFaceLine returned false before its plain check, so the round got no route (up to 6 Bots answered, no last-speaker-first) and no single (a Bot's @ in its answer could call another Bot on). The relay could also pick a Bot post queued with the friend's line as the opener.

How (core/src/host/groups.js):

Test: new #462 test in core/test/rounds.test.js (routed prompt, one answer, the reply's @Chief starts no turn, last speaker first on a follow-up, the friend's line wins over a queued Bot post, @Writer from a friend is unrouted and starts only the Writer). It fails on main. The #295 test now expects one answer to the friend's plain line instead of two. ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1018, social 276, tree 80, timeline 80, scripts 88, interop 37, live-e2e 16; 0 failures). Patches regenerated and checked; docs (core-host, social) and a changelog fragment updated.

Risk tier: T2 (estimate; the controller sets the label)

@Birfy Birfy added agent-pr Pull request opened by an agent bug Something isn't working area:social Friends, invites, grants, Bot Social labels Oct 20, 2026
@Birfy Birfy self-assigned this Oct 20, 2026
@Birfy

Birfy commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Self-review: PASS
Tip SHA: 65bdf1c
Ran:

  • ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (Node 24): pass, 0 failures (core lint + arch-docs OK, plugin lint, build-client --check, ds-bot-patches check, core 1018, social 276, tree 80, timeline 80, .github scripts 88, interop 37, live-e2e 16)
  • New #462 test in core/test/rounds.test.js fails on main (no route on the friend's line) and passes here
  • node scripts/ds-bot-patches.mjs generate + check; node .github/scripts/changelog.mjs check
  • CI at the tip: all checks green (tests-ok pass); risk-gate reports T2
  • Diff re-read against the owner design rules: only face-room routing of a friend's attested line changes; no UI, approval, grant or connector change; Bot-sent lines still go through the usual hold / Auto-send rules
    Not run:
  • Live two-home check on the Mac instances (3080/3081) or against production Bot Social
  • Smoke bench (dev/bench.sh smoke)

@Birfy Birfy added the awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip label Oct 20, 2026
@Birfy
Birfy added this pull request to the merge queue Oct 20, 2026
Merged via the queue into ThinkFlowLab:main with commit 375fa8e Oct 20, 2026
8 checks passed
@Birfy
Birfy deleted the fix/462-friend-line-face-routing branch October 20, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-pr Pull request opened by an agent area:social Friends, invites, grants, Bot Social awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Face room: friend's plain line bypasses face-room routing and no-follow-up rule

1 participant