Repository navigation
Face rooms person-first; per-Bot face-room Auto-send (#457) - #468
Merged
Merged
Conversation
Collaborator
Author
|
Self-review: PASS
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 20, 2026
# Conflicts: # docs/subsystems/core-client.md # docs/subsystems/social.md
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457
What
Face-to-face rooms are now person-first, as the owner decided on 2026-10-20:
FacePersonTile: the person's name,Me (you)for me, with that person's Bots underneath). Group settings and the details drawer show Members · N, where N counts people, with oneFacePersonRowper person (person mark, name, Bots; my Bots open their chat).faceRoomCountcounts people through the newfacePeople.Bot (person), mine too (Chief (SelfB)). This applies in bubble headers (faceBotLabel), Members, and the@menu. In a face room, Everyone in@shows the Bot count (2 Bots).faceMentionablesalso matches left seats, after the live ones, so@Chief (SelfA)no longer re-binds to my own Chief.Researcher (SelfA), name only, with the handle on hover. The globe/handle line and the lowercase id are gone.Auto-send Chief → roomfor each of my Bots in the room. It callssocial/face-auto { botId, on }and is stored in this home'ssettings.faceAutoSend.pending_approvaland Bot Social's hold has no DLP reason or risk flag, the host approves it at once. A flagged line, or a line from a Bot whose switch is off, still waits for the owner's click.auto_approve_face_roomsreads as "every switch on". The first per-Bot change keeps the others on locally and turns the account-wide flag off.Why
Before this fix, the room was still Bot-first: two tiles per person, Members counted Bots, "(you)" appeared on Bots, mentions re-bound after a leave, and bubble headers were bloated. Auto-send was a single account-wide switch.
Test
core/test/face-person-first.test.jscovers: people and count,(you)only on people,FacePersonRow,faceBotLabel, a mention after a leave, the remote header, and my own line.ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: passes, 0 failures (core 1025, social 283).Risk tier: T3 (estimate; matches the risk-gate report; the controller sets the label). It changes when face-room Bot lines are approved, though only behind an explicit per-Bot owner switch and never for flagged holds.