Repository navigation
Conversation
…tivity line per card (ThinkFlowLab#471)
Collaborator
Author
|
Self-review: PASS
|
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #471 (first slice, owner decision 2026-10-20 option a). #471 also lists items the owner deferred (board view, tool-call counts, first-run guide, team views waiting for #51/#149/#55/#57, inbox-side task actions), so this PR does not close it.
What
work.ended, the same ended-turn entries the finish/fail notifications use (Proactive reminders 1/3: event reminders (approval waiting, failed, finished) in app and desktop #353, PR Notify when my own Bots finish or fail a turn, with one Notifications switch #470); no second event source. A card shows while that failure is the latest ended turn in its place (a Bot's own chat or one group), younger than 7 days, and the Bot is not running or waiting for an approval there. A later finished turn clears it, and that chat is then not also in Done. Title: the chat's last line (The last turn did not finish without the Session list); reason: the failure text. Open only.Latest: …(full text on hover): a task's newest note, else what its Bot runs there now (running turns and tasks only), else the chat's last line. Left out when it only repeats the title or reason.turns.js): past the last 20 ended turns, a place's latest turn is kept while it is a failure younger than 7 days (at most 50), so busy Bots elsewhere do not push an unresolved failure out of the inbox. Notifications are unaffected (they already skip entries they told or that predate the window).Test
core/test/inbox.test.js: failed-turn cards (own Bots only, latest-in-place, cleared by running/waiting/a later finished turn, 7 days, badge count, Open only) and the latest-activity row (sources, no repeats, rendering).core/test/approval-notices.test.js: the host keeps a still-latest failure past the last 20 and drops it once a finished turn follows.ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1080, social 296, tree 80, timeline 83, scripts 93, interop 37, live-e2e 16; 0 failures; plugin lint ok; patches check ok; arch-docs OK).Docs:
docs/subsystems/core-client.md(Agent inbox),docs/subsystems/core-host.md(endedView). Changelog:changelog.d/471-inbox-failed-turns.added.md.Risk tier: T2 (estimate; the controller sets the label)