[Birfy]

Fixes #526

#502 (the shared friend's Bot formatter this builds on) is on main (cf61952); this PR now carries only the #526 change.

In a group chat or face-to-face room a friend's Bot read Reviewer · FlyBot 682b8a43 (flybot682b8a43). Two things caused it. Bot Social's member label (<Bot> · <owner>, face-rooms.ts memberLabel) ended up as the Bot's name, so remoteBotTitle then added the owner a second time from the handle (core/src/client/cells.js remoteSpeaker fallback, from the senderName that plugins/social/src/face-rooms.js trustedFaceWho sets). And an owner who never set a name shows as the made-up FlyBot <install id>. Owner decision (2026-10-20, option a): use the #498 person-first name, Bot name plus owner username: Reviewer (flybot682b8a43).

• core/src/shared/remote-label.js: remoteBotName removes a trailing · <owner> only when it matches that Bot's owner. ownerNameOf skips an id-derived owner (isAutoOwnerName: FlyBot + hex id that contains a digit) and uses the username from the home handle instead. If no handle is known, the made-up name stays. seatOwnerName applies the same rule to my own seat (face-seats.js, at-menu.js).
• plugins/social/src/face-rooms.js: faceOwnerName applies the same rule to seats (viewFaceMember.ownerName), join, leave and room-lead lines, and a person's typed line.
• The full handle stays on hover. The remote Bot names in FacePersonRow and the group Members rows (group-settings.js, details-drawer.js) now get title=<handle>, as bubble headers already had.
• Real names are unchanged: Coder (Bob), Ops · Night (Bob), FlyBot, FlyBot2.

Risk tier: T3 (node .github/scripts/risk-gate.mjs --pr 541: display-name and remote-label paths, plugins/social/src/face-rooms.js). Needs the maintainer's approval and a PASS at the tip.

Verification at 01c24e4 (main cf61952 merged in):

• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify → pass. core 1117, social 314, tree 83, timeline 93, .github scripts 93, interop 37, live-e2e 16; 0 failures. arch-docs OK; no new lint warnings (same count as before the merge).
• Red at base (main cf61952, with only the new test files copied in): core/test/group-bot-label.test.js 0/3 pass (actual: 'Reviewer · FlyBot 682b8a43 (flybot682b8a43)', 'Reviewer (FlyBot 682b8a43)'). At base the new social assertions fail on the missing faceOwnerName export. Green at the tip.
• (cd core && npm run build), node scripts/ds-bot-patches.mjs generate and check → ok.

Not run:

• Smoke test: nothing under core/index.js or core/src/host/ changed. The host reads shared/remote-label.js for room labels; unit tests cover that, including presentRoom.
• Desktop, live instances, production Bot Social.

[Birfy]

Self-review (review-pr, Birfy reviewer agent, 2026-10-20 20:26 Asia/Shanghai): PASS

Tip SHA: 6648eae
Ran:

• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify at this tip → pass, 0 failures (core 1117, social 314, tree 83, timeline 93, .github scripts 93, interop 37, live-e2e 16); arch-docs OK (45 changed files, subsystem docs core-client / core-host / social updated); lint warnings the same as the base (81), 0 errors
• (cd core && npm run build); node scripts/ds-bot-patches.mjs generate; node scripts/ds-bot-patches.mjs check → pass (core/ = ds-bot/ + patches; new test stored whole in patches/ds-bot/files/test/)
• red at base: core/test/group-bot-label.test.js copied alone into ae721f7 (Name a friend's Bot one way and approval cards by the receiving person #502 tip without this change) → 0/3 pass (actual 'Reviewer · FlyBot 682b8a43 (flybot682b8a43)' and 'Reviewer (FlyBot 682b8a43)'); green at the tip (3/3). plugins/social/test/face-rooms.test.js Group chat: simplify bot display name to bot name + username #526 test → red at base (faceOwnerName missing), green at the tip
• CI at this tip → all checks pass (tests-ok, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, risk tier, reviewed tip); MERGEABLE / CLEAN
• node .github/scripts/risk-gate.mjs --pr 541 --repo ThinkFlowLab/FlyBot → T3
• diff review (own commit cd7ad95): one changelog.d fragment (526-group-bot-label.fixed.md), no CHANGELOG.md or ds-bot/ edits, client.js regenerated; peer strings still go through cleanPeerName / cleanFaceName before display; a username from the handle passes the same cleaning; no change to fenced model text or to trust
  Not run:
• smoke test — no core/index.js or core/src/host/ change (the host imports shared/remote-label.js; presentRoom labels are covered by the unit test)
• Desktop / live instances / production Bot Social
  Verdict: PASS

Security / display-name: the new helpers only choose between peer strings that were already cleaned (owner name vs the username part of the handle), and they never move a name out of a fence. Findings: no actionable findings. Not merge authority: T3 needs the maintainer's approval, and it merges after #502.

[Birfy]

Self-review (review-pr, Birfy reviewer agent, 2026-10-20 20:48 Asia/Shanghai): PASS

Tip SHA: 01c24e4
Ran:

• merge of origin/main cf61952 (Name a friend's Bot one way and approval cards by the receiving person #502 squash + Show each scheduled task's last run, and Retry a failed one #494) into fix/526-group-bot-label, no rebase / force-push. Conflicts in core/src/client/at-menu.js, docs/subsystems/core-client.md, core-host.md, social.md (main's Name a friend's Bot one way and approval cards by the receiving person #502 text + this PR's Group chat: simplify bot display name to bot name + username #526 addition; resolved to main's Name a friend's Bot one way and approval cards by the receiving person #502 content plus the Group chat: simplify bot display name to bot name + username #526 lines only) and patches/ds-bot/0003, 0008 (generated: took main's patches/ds-bot, regenerated). topics.json unchanged (this PR adds no patch topic)
• (cd core && npm run build); node scripts/ds-bot-patches.mjs generate; node scripts/ds-bot-patches.mjs check → pass (ds-bot/ = pin, 10 patches apply, core/ = ds-bot/ + patches); build-client --check → pass
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (DSH_HARNESS unset, dev/harness packages) at this tip → pass, 0 failures (core 1117, social 314, tree 83, timeline 93, .github scripts 93, interop 37, live-e2e 16); arch-docs OK; lint warnings unchanged from the previous tip (no new ones), 0 errors
• red at base: core/test/group-bot-label.test.js and plugins/social/test/face-rooms.test.js copied alone into main cf61952 → core 0/3 pass (actual 'Reviewer · FlyBot 682b8a43 (flybot682b8a43)', 'Reviewer (FlyBot 682b8a43)'); social file fails on the missing faceOwnerName export. Green at the tip (3/3; social 314/314)
• gh pr diff 541 → the same 19 files as the Group chat: simplify bot display name to bot name + username #526 commit cd7ad95 (source hunks identical, generated files regenerated); no Name a friend's Bot one way and approval cards by the receiving person #502 content left in the diff
• CI at this tip → all checks pass (tests-ok, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, risk tier, reviewed tip); MERGEABLE / CLEAN
• node .github/scripts/risk-gate.mjs --pr 541 --repo ThinkFlowLab/FlyBot → T3
  Not run:
• smoke test — no core/index.js or core/src/host/ change (the host imports shared/remote-label.js; presentRoom labels are covered by the unit test)
• Desktop / live instances / production Bot Social
  Verdict: PASS

Security / display-name: unchanged from the previous review — the helpers only choose between peer strings that were already cleaned (owner name vs the username part of the handle) and never move a name out of a fence. Findings: no actionable findings. Not merge authority: T3 needs the maintainer's approval (#502 is on main, so nothing else blocks it).

[Birfy]

Self-review (review-pr, Birfy reviewer agent, 2026-10-20 Asia/Shanghai): PASS (merge-main conflict fix; no feature change)

Tip SHA: 2f979dc
Ran:

• git merge origin/main twice into the branch, plain merges, no rebase or force-push: first 93dc3c9 (Ask a group's question in that group, not in the Bot's own chat #551) → conflicts only in generated core/client.js and patches/ds-bot/0008-client-bundle.patch, no real source conflicted; then 6824c61 (Save the owner's keys for all of the owner's Bots by default #547) → merged cleanly
• generated files regenerated, not hand-merged: git checkout origin/main -- patches/ds-bot (this branch adds no topics.json entries; its new files live whole in patches/ds-bot/files/, so main's topics.json is complete), (cd core && npm run build), node scripts/ds-bot-patches.mjs generate, check → pass (10 patches apply cleanly; core/ = ds-bot/ + patches); after the second merge build + generate left no diff and build-client --check passed
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify at this tip (core lint + arch-docs OK with 19 changed files, plugin lint, build-client --check, ds-bot-patches check, all suites) → pass, 0 failures (core 1137, social 314, tree 83, timeline 93, .github scripts 93, interop 37, live-e2e 16)
• CI on this tip → all checks pass (tests-ok, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, risk tier, reviewed tip); MERGEABLE / CLEAN
• re-read the diff against main at this tip: same 19 files as before the merges (client, shared remote-label, social face-rooms, tests, docs, generated client.js and patches); one changelog.d fragment (526-group-bot-label.fixed.md); no CHANGELOG.md, version or ds-bot/ edits; no node_modules links committed
  Not run:
• smoke test — PR does not touch core/index.js or core/src/host/
• live Mac instances / DSH Desktop / real-model live-e2e (no key; mock model only)
• production Bot Social (not in scope)
  Verdict: PASS

Findings: none to act on. This review is not merge authority by itself; the maintainer's approval is recorded separately.

[Birfy]

Owner approval in chat 2026-10-20 21:46 Asia/Shanghai: merge.