Skip to content

One PR per issue: update the open one instead of opening a second - #590

Merged
Birfy merged 1 commit into
mainfrom
docs/one-pr-per-issue
Oct 21, 2026
Merged

Birfy merged 1 commit into
mainfrom
docs/one-pr-per-issue

Conversation

@Birfy

@Birfy Birfy commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Risk: T3 (AGENTS.md and the policy docs).

The owner's new hard rule: when an issue already has a pull request, work in that one — do not open a second and close the first. This records it next to the admission line, so the two are read together.

What changes (4 files, +7 -1)

  • AGENTS.md: a new paragraph in the admission-line section — re-base the open branch, use update-branch, or push a commit to its head, and put the tests there too; a contributor's fork is treated the same while it allows maintainer edits; the only exception is a branch that cannot be pushed, and then the reason goes on the issue, never a silent swap.
  • docs/code-standards.md: the same rule as a bullet under "Merge only a reviewed tip".
  • docs/autonomous-dev.md: one sentence in the merge-by-tier item.
  • .claude/skills/fix-issue/SKILL.md: a bullet in step 4 (PR).

It applies to new work from now on: #586 and its closed originals (#535/#539/#568) are left exactly as they are, as the Chief asked.

Checks

  • node --test .github/scripts/*.test.mjs — 93/93.
  • check-arch-docs.mjs with ARCH_DOCS_BASE=HEAD~1 — OK (4 changed files).
  • scripts/ds-bot-patches.mjs check — OK (no code touched).
  • changelog.mjs check — OK; no fragment, a change users cannot see and that ships no code.
  • TZ=UTC.

Not run: one-shot npm run verify (2 GiB OOM in this container), full core suite, smoke, Desktop.

@Birfy Birfy self-assigned this Oct 21, 2026
@Birfy Birfy added agent-pr Pull request opened by an agent area:docs Documentation labels Oct 21, 2026

@Birfy Birfy left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS at c053cca

Tip SHA: c053cca3bdd97ceea96f57ab37a94291fdd5f094
This records the owner's new hard rule (an issue that already has a PR keeps it; update that branch instead of opening a second) next to the admission line, so the two are read together. Scope decision: the owner's own request.
Diff (4 files, +7 -1, no code): `AGENTS.md` (new paragraph in the admission-line section, with the exception and the obligation to write the reason on the issue), `docs/code-standards.md` (bullet under "Merge only a reviewed tip"), `docs/autonomous-dev.md` (one sentence in the merge-by-tier item), `.claude/skills/fix-issue/SKILL.md` (bullet in step 4).
It applies to new work: #586 and the three originals it replaced are untouched, as the Chief asked.
Ran at the tip: CI all green (tests-ok, plugins social/tree/timeline, package, Node 24). On this tree: `node --test .github/scripts/*.test.mjs` 93/93, `check-arch-docs.mjs` with `ARCH_DOCS_BASE=HEAD~1` OK (4 files), `scripts/ds-bot-patches.mjs check` OK, `changelog.mjs check` OK. No fragment: a change users cannot see ships none. TZ=UTC.
Not run: one-shot `npm run verify` (2 GiB OOM), full core suite, smoke, Desktop.
Tier: **T3** (`AGENTS.md`, the policy docs). Enqueueing it myself under the rule it records. Any new commit voids the PASS.

@Birfy
Birfy added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 127676e Oct 21, 2026
8 checks passed
@Birfy
Birfy deleted the docs/one-pr-per-issue branch October 21, 2026 03:27
@Birfy Birfy removed the agent-pr Pull request opened by an agent label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant