Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #992.
threshold_totalcalledthreshon the count before and after each update, also when that count was zero.distinct_totalgives it|_,_| 1, so when a key's count returned to zero it emitted1 - 1 = 0instead of-1. Whether a zero count reachedthreshat all depended on whether the trace had merged away the updates that cancelled.threshold_totalnow gives zero for a zero count and does not callthreshon it.thresholddocuments the same behaviour, anddistinct_totalkeeps its closure.Test plan
tests/threshold.rs:distinct_totalandthreshold_total(with athreshthat does not map zero to zero) on a key that leaves and returns, with all updates in one batch and with one batch for each time. Both tests fail before the change.reducepanics with "upperstraddles batch" when its input frontier is ahead of its trace #990 (the operator runs before the arrange that feeds it), with no failures.count_totalpasses the same check without changes.cargo test --workspace.