Repository navigation
ci(codeql): make the java-kotlin analysis blocking again (closes #26) - #180
Merged
Merged
Conversation
CodeQL CLI 2.27.3 (codeql-action 4.39.0) extracts Kotlin 2.4.21: no "Kotlin version too recent" error on main, and the uploaded java-kotlin analysis carries a finding in a .kt file, so it analyses real Kotlin code. Drop the temporary continue-on-error on the build and analyze steps. Docs: manual build mode, both analyze checks are required. Closes #26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
Seit PR #25 (Kotlin 2.4) lief die CodeQL-Analyse für java-kotlin mit
continue-on-error, weil der Kotlin-Extractor Kotlin 2.4 noch nicht kannte (KotlinVersionTooRecentError). Kotlin-Scanning war damit faktisch aus, der Check trotzdem grün.Nachweis, dass es jetzt wirklich funktioniert (die Step-API meldet bei
continue-on-errorauch Fehlschläge als success, daher am Inhalt geprüft):main@11f8b73(Kotlin 2.4.20) und @2765441(Kotlin 2.4.21, codeql-action 4.39.0): CodeQL CLI 2.27.3, im java-kotlin-Log keintoo recentund kein##[error].kt-Datei (java/spring-disabled-csrf-protection,SecurityConfig.kt:29, der bekannte, als False Positive verworfene Befund). Ein Befund im Kotlin-Quelltext ist nur möglich, wenn der Kotlin-Code tatsächlich extrahiert wurde.Änderung:
codeql.yml: die beiden temporärencontinue-on-error(Build + Analyze) und den TEMPORARY-Kommentar entfernt.analyze (java-kotlin, manual)ist bereits Required Check dermain-Ruleset → ab jetzt echte Merge-Sperre.supply-chain-security.md: "Autobuild" → manueller Build (compileTestKotlin), Required-Check-Status, Hinweis: bei künftigem "too recent" codeql-action bumpen statt Check abschwächen.Der CodeQL-Lauf dieses PRs ist zugleich der Test: Er läuft jetzt ohne Netz und doppelten Boden.
🤖 Generated with Claude Code