Skip to content

Fix the vsync idle setting for RGB displays on ESP32 - #11631

Open
mikeysklar wants to merge 1 commit into
adafruit:mainfrom
mikeysklar:dotclock-vsync-idle
Open

mikeysklar wants to merge 1 commit into
adafruit:mainfrom
mikeysklar:dotclock-vsync-idle

Conversation

@mikeysklar

@mikeysklar mikeysklar commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

What

vsync_idle_low now sets the vsync idle level.

Why

It was set from hsync_idle_low by mistake.

Checked hsync / vsync idle
espressif_esp32s3_devkitc_1_n8r8_hacktablet, espressif_esp32s3_lcd_ev, espressif_esp32s3_lcd_ev_v1.5, makerfabs_tft7, waveshare_esp32_s3_touch_lcd_2_1 False / False
sunton_esp32_8048S050, sunton_esp32_8048S070 True / True
Learn guides Moon_Flight_Tracker, Qualia_820x320_IO_Countdown False / False

The fix only matters when hsync and vsync idle values differ.

Not tested on hardware; no in-tree board changes behavior.

sunton_esp32_8048S050 builds.

AI assistance: written with Claude Code. I checked every caller above myself.

The vsync idle level was taken from hsync_idle_low, so the vsync_idle_low
argument was ignored.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mikeysklar
mikeysklar changed the base branch from 10.3.x to main October 19, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant