Repository navigation
Conversation
…to Vitest migration After migrating projects, the `migrate-karma-to-vitest` migration suggested running `ng g @schematics/angular:refactor-jasmine-vitest <project_name>`. The schematic does not accept a positional project argument, so the suggested command failed with `Unknown argument`. Suggest the `--project <project_name>` option instead.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the suggested command for refactoring Jasmine tests to Vitest in the migration logs to use the --project flag instead of a positional argument. It also adds a corresponding unit test to verify that the correct command is logged. There are no review comments, and I have no feedback to provide.
Collaborator
|
Thanks for this, but the issue here is that the schematic should accept the positional argument. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migrating projects, the
migrate-karma-to-vitestmigration suggested runningng g @schematics/angular:refactor-jasmine-vitest <project_name>. The schematic does not accept a positional project argument, so the suggested command failed withUnknown argument. Suggest the--project <project_name>option instead.