Repository navigation
GH-53995: [C++] Fix FetchContent build failure on CMake < 3.30 - #54457
Open
pratikdeoke wants to merge 1 commit into
Open
pratikdeoke wants to merge 1 commit into
pratikdeoke wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When building Arrow via CMake's FetchContent on versions older than 3.30,
the variable
arrow_SOURCE_DIR(lowercase) gets overridden by FetchContentbecause
project(arrow)sets it as a cache variable while FetchContent setsa normal variable with higher precedence. This causes Arrow to fail finding
thirdparty/versions.txt.What changes are included in this PR?
Replace
arrow_SOURCE_DIRwithARROW_SOURCE_DIRincpp/cmake_modules/ThirdpartyToolchain.cmakeso that Arrow does not relyon the lowercase variable that conflicts with FetchContent on older CMake.
Are these changes tested?
The fix was verified via the workaround patch applied in
apache/iceberg-cpp#1029, which applies the same change and confirmed it
resolves the issue on CMake 3.28.3.
Fixes: #53995