Repository navigation
GH-54489: [CI][Integration] Install jpype1 from conda-forge in conda-integration image - #54490
Merged
Merged
Conversation
…n image Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CurtHagenlocher
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
October 18, 2026 18:21
|
|
Contributor
Author
|
The verification run linked in the description has finished, and the Integration job passed: https://github.com/CurtHagenlocher/arrow-dotnet/actions/runs/39150917107/job/117744207024
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow change follows the existing JPype image pattern, with successful integration validation and no unresolved findings.
No open issues 🎉
What changed in this PR
Preinstalls jpype1 from conda-forge in the integration image, avoiding source-build failures when PyPI lacks wheels for the selected Python version.
Changes:
- Adds
jpype1to the existing mamba installation. - Documents the reason; leaves the integration script unchanged.
| File | Description |
|---|---|
| ci/docker/conda-integration.dockerfile | Installs and documents the conda-provided JPype dependency. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
conda-integrationimage doesn't pin Python, so it now gets Python 3.15.ci/scripts/integration_arrow.shinstalls jpype1 with pip, and PyPI has no cp315 wheel for jpype1 yet. pip falls back to building from source, which fails because the image doesn't include Apache Ant. See #54489 for details.What changes are included in this PR?
Install
jpype1from conda-forge inconda-integration.dockerfile, asconda-python-jpype.dockerfilealready does. conda-forge has builds for Python 3.15 on both linux-64 and linux-aarch64.integration_arrow.shis unchanged: itspip install jpype1finds the conda package already installed and does nothing. It still installs jpype1 when the script runs outside this image.Are these changes tested?
Yes. The Integration job in apache/arrow-dotnet builds this image from scratch and fails with the error above. I ran that job on a fork with the Arrow checkout pointed at this branch, and it got past the jpype1 installation that used to fail. When I opened this PR the run was still in progress: https://github.com/CurtHagenlocher/arrow-dotnet/actions/runs/39150917107
Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
🤖 Generated with Claude Code