Repository navigation
refactor: consolidate AsyncLogger log enqueue paths - #3653
Merged
wwbmmm merged 1 commit intoOct 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused refactor preserves existing behavior and has no identified blocking issues; builds and tests were not run.
No open issues 🎉
What changed in this PR
This PR consolidates AsyncLogger’s duplicated enqueue logic into a private forwarding helper while preserving existing logging behavior.
Changes:
- Share queue admission, shutdown checks, and synchronous fallback logic between both
Logoverloads. - Preserve copying for lvalues and moving for rvalues only after successful request allocation.
| File | Description |
|---|---|
src/butil/logging.cc |
Introduces LogInternal and copy/move enqueue helpers to remove duplicated control flow. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
AsyncLogger::Log(const LogInfo&)andAsyncLogger::Log(LogInfo&&)duplicatethe same queue admission, shutdown, and synchronous fallback logic. Keeping
these paths separate makes future changes easier to diverge.
What is changed and the side effects?
Changed:
successfully allocated.
stopped, or allocation fails.
Side effects:
No intended behavioral change.
Performance effects:
No expected material performance change. The rvalue path still moves the
LogInfointo the queued request.Breaking backward compatibility:
No. This refactors private implementation details only.
Check List: