Repository navigation
refactor: consolidate MPSCQueue enqueue paths - #3655
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused refactor preserves value categories, allocation, and synchronization, with no unresolved findings.
No open issues 🎉
What changed in this PR
Consolidates the duplicated MPSCQueue enqueue paths into a private forwarding helper without changing the public API or queue behavior.
Changes:
- Shares node allocation, initialization, and enqueue logic between both overloads.
- Preserves copy semantics for lvalues and move semantics for rvalues.
| File | Description |
|---|---|
src/butil/containers/mpsc_queue.h |
Adds EnqueueInternal and delegates both enqueue overloads to it. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
MPSCQueue<T>::Enqueue(const T&)andMPSCQueue<T>::Enqueue(T&&)duplicatethe node allocation and enqueue logic. The only behavioral difference is
whether the task value is copied or moved.
What is changed and the side effects?
Changed:
inputs.
Side effects:
No intended behavioral change.
Performance effects:
No expected performance impact. Node allocation and queue operations are
unchanged.
Breaking backward compatibility:
No API or ABI changes.
Check List: