Skip to content

UI: exclude SYSTEM/ROUTING templates from Deploy Instance (#14414) #14420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nabassa1323 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

UI: exclude SYSTEM/ROUTING templates from Deploy Instance (#14414) #14420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ui/src/views/compute/DeployVM.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2995,6 +2995,21 @@ export default {
}
this.fetchAllTemplates(params)
},
isDeployableUserTemplate (template) {
// System / routing templates must not appear in Deploy Instance (admins see them via templatefilter=all)
return template && template.templatetype !== 'SYSTEM' && template.templatetype !== 'ROUTING'
},
filterDeployableTemplates (listTemplatesResponse) {
if (_.isEmpty(listTemplatesResponse)) {
return { count: 0, template: [] }
}
const templates = (listTemplatesResponse.template || []).filter(this.isDeployableUserTemplate)
return {
...listTemplatesResponse,
template: templates,
count: templates.length

@Damans227 Damans227 Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wont this break paging? the pager reads this count as the total, so with 25 templates it shows only the first 10 and no page 2

}
},
fetchAllTemplates (params) {
const promises = []
const templates = {}
Expand All @@ -3008,7 +3023,7 @@ export default {
this.options.templates = templates
return Promise.all(promises).then((response) => {
response.forEach((resItem, idx) => {
templates[templateFilters[idx]] = _.isEmpty(resItem.listtemplatesresponse) ? { count: 0, template: [] } : resItem.listtemplatesresponse
templates[templateFilters[idx]] = this.filterDeployableTemplates(resItem.listtemplatesresponse)
this.options.templates = { ...templates }
})
this.updateSelectedTemplateHypervisor()
Expand Down