Repository navigation
core: Refresh cached file info from the open fd in default_handler. - #865
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
r->finfo was left as populated by the directory walk's stat() on the pathname, even after the file is opened. A rename(2) racing with that open() leaves the fd pointing at a different file than the one that was stat()'d, so Last-Modified, ETag, Content-Length and the byte range actually sent end up describing the old file while the content comes from the new one. Refresh r->finfo from the already-open file descriptor right after open(), before any of that is computed. PR 54962.
arturobernalg
force-pushed
the
fix/httpd-54962-stale-file-stat
branch
from
October 21, 2026 05:23
49a1d0e to
d362e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r->finfo was left as populated by the directory walk's stat() on the pathname, even after the file is opened. A rename(2) racing with that open() leaves the fd pointing at a different file than the one that was stat()'d, so Last-Modified, ETag, Content-Length and the byte range actually sent end up describing the old file while the content comes from the new one.
Refresh r->finfo from the already-open file descriptor right after open(), before any of that is computed.
PR 54962.
A rename() of the requested file racing with the handler's open() leaves the fd pointing at a different file than the one the directory walk stat()'d, so Last-Modified, ETag, Content-Length and the Range handling all end up describing the old file while the body comes from the new one. Refreshes r->finfo from the already-open fd before any of that is computed.
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.