Repository navigation
core: Add ap_custom_response_ct() to set the Content-Type of a custom response. - #866
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
… response. ap_custom_response() always sends a plain text response as text/html. The new function registers the Content-Type together with the text, so a handler can send for example application/json. ap_custom_response() is unchanged. PR 69430.
arturobernalg
force-pushed
the
fix/httpd-69430-custom-response-ct
branch
from
October 21, 2026 05:22
f079386 to
b2e5a2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ap_custom_response() sends a plain text response as text/html, whatever Content-Type the handler had set, so an error cannot be answered with a JSON body and application/json. This adds ap_custom_response_ct(), which registers the Content-Type together with the text and sends it with that type. It only applies to a static text, not to a file or a URL, and a later ap_custom_response() for the same status takes it away again. GET and HEAD send the same type.
I first tried to keep the Content-Type the handler had already set, without a new function, but the request does not tell who set it. A type left by mod_mime or ForceType, or by another handler that returned DECLINED, ended up on the error body, so the API is explicit.
Modules that call ap_set_content_type() and then ap_custom_response() still get text/html and have to switch to the new function. ap_custom_response() itself is unchanged.
The test needs a C module, so it is in test/pytest_suite. The MMN is bumped to 20211221.34.
PR 69430.
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.