Repository navigation
Conversation
Tested locally with: - prek run -a - pre-commit run --all-files ASF infra approved: https://github.com/apache/infrastructure-actions/blob/e3e0a2261a9c6d5bdd882802b303f34b1511b6df/approved_patterns.yml#L236 j178/prek-action@1382ad7 actions/checkout@3d3c42e
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open findings
What changed in this PR
Updates the CI pre-commit workflow to use the ASF-approved j178/prek-action pattern instead of manually installing dependencies and invoking pre-commit.
Changes:
- Switches the workflow runner from
ubuntu-24.04toubuntu-latest. - Replaces manual Python/pip install +
pre-commit runwith pinnedactions/checkout+j178/prek-action. - Removes the explicit
actions/cacheconfiguration previously used for pre-commit hook caching.
| File | Description |
|---|---|
| .github/workflows/pre-commit.yml | Migrates pre-commit CI execution to the ASF-approved prek-action approach. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| pre-commit: | ||
| name: Run pre-commit | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-latest |
| key: pre-commit|${{ env.PY }}|${{ hashFiles('.pre-commit-config.yaml') }} | ||
| - name: Run pre-commit | ||
| run: pre-commit run --color=always --all-files | ||
| persist-credentials: false |
| - name: Set PY | ||
| run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV | ||
| - uses: actions/cache@v5 | ||
| - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )" |
Copilot stopped reviewing on behalf of
jbampton due to an error
October 14, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested locally with:
ASF infra approved:
https://github.com/apache/infrastructure-actions/blob/e3e0a2261a9c6d5bdd882802b303f34b1511b6df/approved_patterns.yml#L236
j178/prek-action@1382ad7
actions/checkout@3d3c42e
Examples:
https://github.com/apache/shiro/blob/main/.github/workflows/pre-commit.yml
https://github.com/apache/sedona/blob/master/.github/workflows/pre-commit.yml