[adoroszlai]

What changes were proposed in this pull request?

.mvn/develocity.xml currently enables:

• local and remote build cache lookup
• build scan collection
• if authenticated (GitHub CI in apache/ozone): publishing build scans and saving to remote build cache

Remote Develocity server is set to the ASF's instance.

Changes proposed:

• move existing config file to .mvn/develocity-asf.xml
• create new .mvn/develocity.xml, which only enables local build cache, nothing else
• use .mvn/develocity-asf.xml in CI via CLI options

Developers can opt-in to using ASF's Develocity using the same options.

Benefits:

• avoid unintended usage of remote cache, which may falsify "reproducible build" results (e.g. in [reproducible-central|https://github.com/jvm-repo-rebuild/reproducible-central])
• avoid local overhead and server-side load of remote cache lookups for builds that cannot possibly be cached there (e.g. company internal builds)
• avoid overhead of scan data collection for local builds by default

https://issues.apache.org/jira/browse/HDDS-17109

How was this patch tested?

Verified that local cache is enabled by default, but remote cache is not:

$ mvn -N clean \
    -Dorg.slf4j.simpleLogger.log.develocity.goal.cache=debug
...
[DEBUG] Develocity Maven Extension: 2.6.0
[DEBUG] Using the build cache with the following configuration:
  Local build cache: enabled
      storeEnabled: true
      directory: ~/.m2/.develocity/build-cache
      cleanup: enabled
          retention: P7D
          interval: P1D
  Remote build cache: disabled:
      Build caching requires a Develocity server and none was specified.
...

Verified remote cache is enabled via the property used in CI workflows:

$ mvn -N clean \
    -Dorg.slf4j.simpleLogger.log.develocity.goal.cache=debug \
    -Ddevelocity.user.config=$(pwd)/.mvn/develocity-asf.xml
...
[DEBUG] Develocity Maven Extension: 2.6.0
[DEBUG] Using the build cache with the following configuration:
  Local build cache: enabled
      storeEnabled: true
      directory: ~/.m2/.develocity/build-cache
      cleanup: enabled
          retention: P7D
          interval: P1D
  Remote build cache: enabled
      url: https://develocity.apache.org/cache/
      authentication: none
      storeEnabled: false
...

CI:
https://github.com/adoroszlai/ozone/actions/runs/39220897550

[chihsuan]

Thanks for the patch! @adoroszlai Looks good overall, left a few small questions inline.

Also, should we add MAVEN_ARGS to repeat-acceptance.yml too?

[chihsuan]

Just curious, could develocity-asf.xml only hold the overrides, since the configs are merged? Happy either way.

[adoroszlai]

Makes sense. Tested with the same command as in description.

[chihsuan]

Should we set resourceUsage to true in develocity-asf.xml? I noticed master CI scans include CPU and memory charts today, but this false may carry over through the config merge.

[adoroszlai]

Added. I couldn't find a way to see the effective value (as opposed to the cache, which has the debug setting). /proc/cpuinfo etc. are read once with both values, so not sure what this does.

[chihsuan]

Per the docs, it controls the CPU / Memory / Disk / Network charts in the scan's Performance tab, e.g. https://develocity.apache.org/s/ze3mlrultacfs/performance. I think we can check the next master scan after the merge.

[chihsuan]

Thanks @adoroszlai LGTM +1

[adoroszlai]

Thanks @chihsuan for the review.