Repository navigation
GH-3289: Test index and statistics commands through CLI arguments - #3868
Open
zhangxinyao88 wants to merge 1 commit into
Open
zhangxinyao88 wants to merge 1 commit into
zhangxinyao88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing index and statistics tests mostly invoke command objects directly, leaving CLI column/row-group selection and output options unverified. Add seventeen cases through the shared CLI helper for
column-index,column-size,bloom-filter,size-statsandcheck-stats.A deterministic two-row-group fixture checks index modes and selection, footer-backed column sizes, nested-column aggregation, sorting and percentages, typed Bloom membership and missing filters, byte counts and level histograms, unavailable metadata, and multiple-file success/failure handling. This adds tests only and leaves geospatial and rewrite coverage separate.
Validation on Java 17:
./mvnw -o -B -ntp -pl parquet-cli spotless:check testpassed with 100 tests, 98 passed and 2 skipped; Spotless and RAT passed. Eleven temporary argument/output regressions triggered assertion failures and were restored before the final run.The current-source Hadoop module was rebuilt successfully using cached prerequisites. A prerequisite reactor build stopped at its Thrift version check (required 0.25.0, installed 0.24.0); full-reactor and other-JDK validation are not claimed.
Related to #3289; this covers independent remaining commands and does not close the parent tracker.