Repository navigation
Add Manager session timeout editing - #1086
Open
sainadh777 wants to merge 2 commits into
Open
sainadh777 wants to merge 2 commits into
sainadh777 wants to merge 2 commits into
Conversation
Contributor
Author
|
@markt-asf @rmaucher — would you please review the Manager session-timeout UI and action? You both recently changed the same Manager session code and tests. |
markt-asf
requested changes
Oct 16, 2026
markt-asf
left a comment
Contributor
There was a problem hiding this comment.
No objections to the general direction of this PR. I do have a few questions on the test changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale and impact
The session detail page displayed the maximum inactive interval but left updating it as an unfinished TODO. This completes that workflow through the existing CSRF-protected Manager HTML endpoint. The change is limited to the Manager web application and does not alter container defaults or session behavior outside an explicit administrator update.
Validation
ant validate validate-eoln— passedant -Dtest.entry=org.apache.catalina.manager.TestManagerWebapp test— 5 tests, 0 failures, 0 errors, 0 skippedant clean deploy— passedant clean test— 42,084 tests, 0 failures, 0 errors, 364 environment-declared skipsGET /returned HTTP 200, and Tomcat stopped cleanlyThe complete suite and runtime smoke ran with Eclipse Temurin JDK 25 on a native Linux case-sensitive Docker volume.