Repository navigation
Conversation
…er.get_multiple
_get_multiple appended the generated {"Key": "name"} filter to the list passed
through sdk_options["Filters"]. When callers reuse a module-level Filters
constant, as the documentation example does, every call left a stale name
filter behind and the next request sent all of them.
Build a new list instead of mutating the caller's one, and cover the reuse
case with a regression test.
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
powertools-for-aws-oss-automation
Bot
added
the
size/M
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8596
Summary
Changes
SecretsProvider.get_multipleappended the generated{"Key": "name"}filter directly to the list passed throughsdk_options["Filters"]. Reusing a module-levelFiltersconstant, as the documentation example does, accumulated one stalenamefilter per call, so every subsequent request also sent the names from previous calls.This builds a new list instead of mutating the caller's one, and adds a regression test that calls
get_multipletwice with the sameFilterslist, asserting both the request payload sent tobatch_get_secret_valueand the caller's list afterwards.User experience
Before — the caller's
Filterslist grows on every call and later requests contain stalenamefilters:[{'Key': 'primary-region', ...}, {'Key': 'name', 'Values': ['a']}, {'Key': 'name', 'Values': ['b']}]After — the caller's list stays untouched and each request sends only its own filter set:
[{'Key': 'primary-region', ...}]By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.