Skip to content

perf(storage-overlay): register proof cursor metrics on first multiproof #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrianBland wants to merge 1 commit into from
Closed

perf(storage-overlay): register proof cursor metrics on first multiproof #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions crates/storage/storage-overlay/src/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ where
Some(self.overlay_builder.clone()),
Arc::clone(&self.state_trie_overlay_cache),
self.metrics.clone(),
self.proof_cursor_metrics.clone(),
Some(self.proof_cursor_metrics.clone()),
self.known_storage_roots.clone(),
is_v2,
))
Expand All @@ -174,7 +174,9 @@ where
overlay_builder: Option<OverlayBuilder<N>>,
state_trie_overlay_cache: StateTrieOverlayCache,
metrics: OverlayStateProviderFactoryMetrics,
proof_cursor_metrics: ProofCursorMetrics,
/// Cursor metric handles for multiproof calculators. Providers built outside a factory
/// register them on their first multiproof, so opening a provider stays cheap.
proof_cursor_metrics: Option<ProofCursorMetrics>,
/// Revealed storage roots from the reused sparse trie, shared across proof workers.
known_storage_roots: Arc<B256Map<B256>>,
state_trie_overlay: OnceCell<StateTrieOverlay>,
Expand Down Expand Up @@ -274,7 +276,7 @@ where
overlay_builder: Option<OverlayBuilder<N>>,
state_trie_overlay_cache: StateTrieOverlayCache,
metrics: OverlayStateProviderFactoryMetrics,
proof_cursor_metrics: ProofCursorMetrics,
proof_cursor_metrics: Option<ProofCursorMetrics>,
known_storage_roots: Arc<B256Map<B256>>,
is_v2: bool,
) -> Self {
Expand Down Expand Up @@ -793,7 +795,7 @@ where
self.provider().tx(),
input,
self.is_v2,
self.proof_cursor_metrics.clone(),
self.proof_cursor_metrics.clone().unwrap_or_default(),
self.known_storage_roots.clone(),
)
};
Expand Down
Loading