Repository navigation
refactor: remove unused vibenet and data service code - #205
Open
0x00101010 wants to merge 3 commits into
Open
0x00101010 wants to merge 3 commits into
0x00101010 wants to merge 3 commits into
Conversation
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
Co-authored-by: Toshi <toshi-noreply@coinbase.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🟡 Heimdall Review Status
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes code nothing in the repo reaches, from files changed in the last 7 days:
featuresFromConfigand its private helpersisConfigFeature/ConfigFeatureinapp/vibenet/data/features.ts.resetDataServiceinapp/scaling/runs/lib/dataService.ts.dataService.tsthat repeated the class comment and described history.No behavior change:
git grepfinds no references to the removed symbols.Screenshots
N/A (no visual changes; only unreferenced code and a comment are removed)
Test plan
Review: ready | high, 93% | claude-sonnet-5-5 + gpt-6-luna
Not verified beyond CI.