Repository navigation
Remove duplicate MockPNPM from mocks_test.go - #971
Merged
Merged
Conversation
tnikolova82
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a compile error introduced when PR #964 and the libbuildpack update (#966) landed together.
PR #966 ran
go generatewhich regeneratedmocks_test.goand automatically includedMockPNPM(with bothBuildandRebuild) since thePNPMinterface already hadRebuildfrom PR #964. This left a duplicate of the hand-writtenMockPNPMblock from #964, causing:The fix removes the hand-written block; the generated one (which includes
Rebuild) is authoritative.Test plan
go test ./src/nodejs/supply/...passes