Repository navigation
Conversation
Class bodies compile free-variable reads as LOAD_NAME (and sometimes LOAD_FROM_DICT_OR_GLOBALS), not LOAD_GLOBAL. Include those loads when extracting globals for by-value functions, but ignore LOAD_NAME names that were already STOREd in the same class body so a local assignment that shadows an unpicklable global does not break pickling. Fixes cloudpipe#609.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #609.
Globals referenced only inside a nested class body were omitted from by-value function pickles because
_walk_global_opsonly consideredLOAD_GLOBAL/STORE_GLOBAL. Class bodies useLOAD_NAME(and on 3.12+, sometimesLOAD_FROM_DICT_OR_GLOBALSfor annotations / type aliases).This change treats those loads as global references for non-
CO_OPTIMIZEDcode objects. To avoid the compatibility trap noted on the issue — a class-local name that shadows an unpicklable global —LOAD_NAMEis counted only when it appears before anySTORE_NAMEof the same name in that class body.Test plan
test_class_body_reads_globals_by_value(issue repro)test_class_body_local_shadow_skips_unpicklable_global(shadowedthreading.Lock)