Repository navigation
Fix pickling modules with cyclic references - #615
Open
David-the-happy-piglet wants to merge 1 commit into
Open
David-the-happy-piglet wants to merge 1 commit into
David-the-happy-piglet wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing a module by value fails with
PicklingError: Could not pickle object as excessively deep recursion requiredwhen its state refers back to the module, including through circular package imports. Functions referencing such a package also fail to serialize.Restore module state after construction so pickle can memoize the module before traversing back-references. Keep the existing reconstruction helper and by-reference behavior. Add regressions for self-references, aliases, circular packages and functions using them, including fresh-process round trips with protocols 2, 4 and 5.
Validation on macOS arm64:
tests/cloudpickle_ipykernel_test.py; that formatting is not included.Windows, Linux and downstream Dask/Ray suites were not run.