Repository navigation
Fix containerCommit() to not pause container if $pause is false - #103
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the serialization issue and includes regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes containerCommit() so $pause = false prevents pausing on older Docker versions while preserving default behavior.
Changes:
- Serializes
pauseexplicitly as1or0. - Adds regression coverage verifying
pause=0when pausing is disabled.
| File | Description |
|---|---|
| tests/ClientTest.php | Adds a regression test for committing without pausing. |
| src/Client.php | Encodes the pause flag as an explicit numeric value. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes
containerCommit()to not pause the container if$pauseis false. It previously sent an emptypause=parameter, which Docker 25 (2024) and older treat like the default and pause the container anyway, so the option had no effect there. It now sendspause=0, which works on all Docker versions. Docker 26 (2024) and newer already treated the empty value as false. This has been broken sincecontainerCommit()was added in #74.Builds on top of #74