Repository navigation
Fix execCreate() to send numeric $user as string - #104
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix preserves string inputs and includes targeted regression coverage, with no unresolved issues.
No open issues 🎉
What changed in this PR
Fixes execCreate() so integer user IDs are serialized as strings, avoiding Docker’s 400 Bad Request response.
Changes:
- Casts
$userto a string before JSON serialization. - Adds a regression test verifying integer
1000is sent as"1000".
| File | Description |
|---|---|
| tests/ClientTest.php | Adds numeric user ID regression coverage. |
| src/Client.php | Serializes the exec user as a string. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes
execCreate()to send a numeric$useras string. The$userparameter accepts astring|int, but a numeric user ID such as1000was sent as a JSON number, which Docker rejects with400 Bad Request. This has been broken since the parameter was added in #39 (2016), passing the user ID as a string such as'1000'worked as a workaround.Builds on top of #39