Skip to content

Update to construct URLs without dependency on rize/uri-template - #106

Merged
clue merged 2 commits into
clue:1.xfrom
clue-labs:remove-uri-templates
Oct 18, 2026
Merged

clue merged 2 commits into
clue:1.xfrom
clue-labs:remove-uri-templates

Conversation

@clue

@clue clue commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

This changeset updates the client to construct its request URLs without the dependency on rize/uri-template. It now uses plain rawurlencode() calls, so consumers of this package no longer install the extra package. The dependency was added with #23 back in 2015 and needed updates for each new PHP version since, see #88, #93 and #94.

The second commit replaces the internal boolArg() helper with inline conditionals, so each endpoint shows the exact value it sends.

All requests stay exactly the same, so this should be safe to apply. Arguments of invalid types may now be rejected with a TypeError instead of silently sending an invalid request.

Builds on top of #94, #93, #88 and #23
Refs rize/UriTemplate#29

@clue clue added the new feature New feature or request label Oct 18, 2026
@clue clue added this to the v1.7.0 milestone Oct 18, 2026
@clue
clue requested a balanced review from Copilot October 18, 2026 11:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@clue
clue force-pushed the remove-uri-templates branch from 293f81f to 1ad9160 Compare October 18, 2026 11:37
@clue clue changed the title Remove unneeded dependency on rize/uri-template Update to construct URLs without dependency on rize/uri-template Oct 18, 2026
@clue
clue requested a balanced review from Copilot October 18, 2026 11:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The refactor preserves supported request behavior, and no blocking issues were identified.

No open issues 🎉

Review effort: Balanced

@clue
clue merged commit 727bf77 into clue:1.x Oct 18, 2026
15 checks passed
@clue
clue deleted the remove-uri-templates branch October 18, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants