Repository navigation
fix(store-gateway): ensure Parquet bucket store honors query sharding - #7892
Open
SungJin1212 wants to merge 1 commit into
Open
SungJin1212 wants to merge 1 commit into
SungJin1212 wants to merge 1 commit into
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
fix-parquet-store-query-sharding
branch
from
October 23, 2026 12:35
c7f679f to
c2e2565
Compare
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
parquetBucketStore.Seriesignores the query sharding info of a Series request. It injectsreq.ShardInfointoctx, but the nexterrgroup.WithContext(srv.Context())shadowsctxwith the original request context.shard.Querytherefore never sees the shard info,materializedLabelsFilterCallbackdoesn't filter, and every vertical shard gets back all series.This PR passes the shard-aware
ctxtoerrgroup.WithContext.LabelNames/LabelValuesalready do this.I've noticed this in https://github.com/cortexproject/cortex/actions/runs/39948129153/job/120397954890?pr=7689
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags