Repository navigation
fix(pstack): name every skill after its folder - #702
Merged
Merged
Conversation
…folder Cursor runs a skill by its folder name. Claude Code lists it by its frontmatter `name`, so a skill named `Poteto Mode` shows up as `/pstack:Poteto Mode`, which parses as the unknown command `/pstack:Poteto`. The Agent Skills spec requires the two to match and limits them to lowercase words joined by hyphens, at most 64 characters. The generator now fails on any pstack skill that breaks that rule. CI runs it with --check. This commit fails on `make-bot-ui` and `poteto-mode`; the next commit renames them.
`make-bot-ui` and `poteto-mode` had the display names `Make Bot UI` and
`Poteto Mode` in their frontmatter. Claude Code listed them as
`/pstack:Make Bot UI` and `/pstack:Poteto Mode`, which cannot run, and Cursor
warned that the name did not match the folder. The fix is in the source, so
Cursor, Claude Code, and the generated tree all read the same name and the
generator needs no per-harness rewrite.
Every skill was renamed by this script, run from the repository root. It
changes only the two skills whose name differed:
node -e 'const fs=require("fs");for(const d of fs.readdirSync("pstack/skills")){const p=`pstack/skills/${d}/SKILL.md`;if(fs.existsSync(p))fs.writeFileSync(p,fs.readFileSync(p,"utf8").replace(/^(---\n[\s\S]*?^name: ).*$/m,`$1${d}`))}'
node scripts/generate-pstack-harness-trees.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two pstack skills had display names in their frontmatter:
make-bot-uiwasMake Bot UIandpoteto-modewasPoteto Mode. Claude Code lists a skill by that name, so it showed/pstack:Make Bot UIand/pstack:Poteto Mode, which parse as the unknown commands/pstack:Makeand/pstack:Poteto. Cursor runs a skill by its folder name and warns when the two differ. This PR fixes the names in the source, so every harness reads the same name and no harness needs a rewrite.What changed
nameofmake-bot-uiandpoteto-modeis now the folder name. The Claude Code tree is regenerated.generate-pstack-harness-trees.mjsfails when a skill'snameis not its folder name, or when the folder name is not lowercase words joined by hyphens, at most 64 characters. CI already runs it with--check.Scope
third_party/, which have the same problem. They are not in the Claude Code marketplace. A repo-wide check can follow after their owners rename them.Tradeoffs
nameonly in the generated Claude Code tree. That fixes Claude Code, but the source still breaks the Agent Skills spec, Cursor still warns, and the two trees give one skill two names. Any other host that readspstack/directly also gets the display name.Blast Radius
Cursor commands stay
/make-bot-uiand/poteto-mode. Only their label in the slash menu changes from the display name to the folder name. Claude Code now lists/pstack:make-bot-uiand/pstack:poteto-mode, which run. The old listed forms never ran, so no alias is needed.Verification
supportedCommands()for the Claude Code tree: 2 broken names of 54 onmain→ 0 on this branch.pstack/skills: 2 warnings onmainand on fix(pstack): name Claude Code skills after their folders #696 → 0 on this branch.generate-pstack-harness-trees.mjs --checkfails on the first commit with the two names and passes on the second.validate-plugins.mjspasses.Note
Low Risk
Naming and generator validation only; no auth, data, or runtime behavior changes beyond slash-menu labels and Claude Code command strings.
Overview
Aligns pstack skill frontmatter
namewith each skill’s folder slug so Cursor and Claude Code invoke the same identifier.make-bot-uiandpoteto-modeno longer use title-case display names (Make Bot UI,Poteto Mode). Claude Code can list runnable/pstack:make-bot-uiand/pstack:poteto-modeinstead of broken commands that stopped at the space.generate-pstack-harness-trees.mjsnow fails the harness check when frontmattername≠ folder name, or when the folder is not a lowercase hyphenated slug (Agent Skills-style, ≤64 chars). That blocks the mismatch from coming back in CI (--check).Reviewed by Cursor Bugbot for commit 72e97b8. Bugbot is set up for automated code reviews on this repo. Configure here.