Skip to content

ci: run cs-fix on the minimum supported PHP - #45

Merged
roxblnfk merged 1 commit into
1.xfrom
ci/cs-fix-php
Oct 22, 2026
Merged

roxblnfk merged 1 commit into
1.xfrom
ci/cs-fix-php

Conversation

@roxblnfk

Copy link
Copy Markdown
Member

🔍 What was changed

  • The cs-fix job now runs on PHP 8.0 instead of the default of the reusable workflow.

🤔 Why?

  • feat: optional bamarni-bin tool and command inputs for the psalm and cs-fix workflows spiral/gh-actions#14 sets the default php of cs-fix.yml to 8.2 and installs the root with --ignore-platform-req='ext-*' instead of --ignore-platform-reqs, so the PHP version is now checked. Each caller passes its own minimum PHP explicitly.
  • PHP 8.0: require.php is >=8.0 and the root with dev dependencies resolves on 8.0 (checked with config.platform.php); the phpunit matrix already covers 8.0.
  • On PHP 8.0 spiral/code-style resolves to 2.3.x: 2.4 needs PHP 8.2, so its import ordering rules are not applied here.

📝 Checklist

  • How was this tested:
    • Tested manually: strict install with config.platform.php 8.0 and php-cs-fixer fix --dry-run locally (PHP 8.1 runtime)

spiral/gh-actions#14 defaults the reusable cs-fix workflow to PHP 8.2 and stops ignoring the PHP platform requirement, so each caller passes its own minimum PHP.

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
@roxblnfk
roxblnfk merged commit 8adbc97 into 1.x Oct 22, 2026
27 checks passed
@roxblnfk
roxblnfk deleted the ci/cs-fix-php branch October 22, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant