Repository navigation
fix: exclude missing values from quantileIndex ranks - #287
Open
LucasLeao18 wants to merge 1 commit into
Open
LucasLeao18 wants to merge 1 commit into
LucasLeao18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quantileIndex([0, null, 100], 0.5) currently returns 2: missing values are ordered last but still increase the population used to calculate the rank. Filter the index array to defined numeric values before calculating the rank, while retaining original input indices.
Add coverage for null, undefined, NaN, accessors, all-missing input, and medianIndex.
Validation (Node.js 24.15.0, Windows): Both added regression cases fail before the fix. npm test passes: 531 passing, 1 pending, including ESLint.
AI assistance: this contribution was prepared with OpenAI Codex; the change and regression results were reviewed before submission.