Repository navigation
refactor: remove unreferenced code across app, bonsplit and tests - #423
Merged
Merged
Conversation
Delete helpers, views and types that nothing references in Sources, vendor/bonsplit, both test targets, tests_v2/programa_client.py and scripts/gen-v2-contract.py. The first-responder bypass in WindowSwizzles.swift had no callers, so its depth counter was always zero; remove it with the early return it guarded. Collapse the UI-test CLI strategy enum to the one case ever used, drop empty MARK sections and double blank lines, and reword three history-narrating comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes code that nothing calls, so the app, the tests and the vendored split library carry less weight and read faster. No behaviour changes: every removed symbol had zero references outside its own definition, and the only logic edit deletes a branch that could never run.
Summary
Sources/,vendor/bonsplit, the unit and UI test targets,tests_v2/programa_client.pyandscripts/gen-v2-contract.py. About 1330 lines.Sources/WindowSwizzles.swift: the first-responder bypass helper had no callers, so its depth counter was always zero. The helper, the counter and the always-false early return inprograma_makeFirstResponderare gone.programa_sendEventis untouched.programaUITests/MultiWindowNotificationsUITests.swift: about 500 lines of unused CLI-driven helpers removed. The CLI strategy enum collapsed to the one case that was ever used.MARK:sections. Three history-narrating comments reworded to present tense.project.pbxprojis unchanged.Review order: start with
Sources/WindowSwizzles.swift(the one logic deletion), thenSources/TerminalController+Debug.swiftandSources/SidebarVisuals.swift. The rest is unreferenced symbols and whitespace.Test plan
CIworkflow green, includingunit-testsand the UI jobs, since both test targets lost helpers.python3 scripts/check-structural-budgets.pyprintsstructural budgets: PASS.scripts/check-v2-contract.shprintsv2 contract check: OK.python3 scripts/check-settings-docs.pyprintsok:.node --test scripts/*.test.jsreports 0 failures.