Skip to content

acc: record main's behaviour for reference, override and required-field edge cases - #7130

Draft
denik wants to merge 4 commits into
mainfrom
denik/acc-record-main-behaviour
Draft

denik wants to merge 4 commits into
mainfrom
denik/acc-record-main-behaviour

Conversation

@denik

@denik denik commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Stack, 1 of 4. Bottom of the stack for #7098; next: #7145, then #7143, then #7098.

Changes

Add four acceptance tests that record how main handles edge cases of references, overrides and required fields:

  • override/cluster_id_clears_new_cluster_reference
  • override/preset_clears_forced_schedule_reference
  • resource_deps/whole_map_reference_hides_entries
  • validate/required_struct_reference

Why

Records today's behaviour before it changes in #7098, so that PR's diff shows what moves.

Tests

Goldens generated on main.

This pull request and its description were written by Isaac.

@github-actions github-actions Bot added the DABs DABs related issues label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 0617a1d4b | Workflow run

Regression test report

Selected 5 changed tests (limit=20, 0 not selected)

10 tests: regression=0 unreleased=0 coverage=10 failing=0

test branch main (16d722d) latest (v1.22.0)
TestAccept/bundle/override/cluster_id_clears_new_cluster_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/override/cluster_id_clears_new_cluster_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/override/preset_clears_forced_schedule_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/override/preset_clears_forced_schedule_reference/DMS=true ✅ ✅ ✅
TestAccept/bundle/resource_deps/whole_map_reference_hides_entries/DMS= ✅ ✅ ✅
TestAccept/bundle/resource_deps/whole_map_reference_hides_entries/DMS=true ✅ ✅ ✅
TestAccept/bundle/validate/nulls/target_adds_null_keeps_it/DMS= ✅ ✅ ✅
TestAccept/bundle/validate/nulls/target_adds_null_keeps_it/DMS=true ✅ ✅ ✅
TestAccept/bundle/validate/required_struct_reference/DMS= ✅ ✅ ✅
TestAccept/bundle/validate/required_struct_reference/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 0617a1d

Run: 39759094811

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 281 20 4:29
✅​ aws-windows-latest-4core-16gb 283 18 3:39
✅​ azure linux-2core-8gb 280 20 4:32
✅​ azure-windows-latest-4core-16gb 282 18 3:19
✅​ gcp linux-2core-8gb 281 20 4:54
🔄​ gcp-windows-latest-4core-16gb 1 282 18 5:25
Test Name gcp-windows-latest-4core-16gb
🔄​ TestAccept 🔄​f
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:03 aws-windows-latest-4core-16gb TestAccept
2:51 azure-windows-latest-4core-16gb TestAccept
2:21 gcp-windows-latest-4core-16gb TestAccept

@denik
denik force-pushed the denik/acc-record-main-behaviour branch from c5340b5 to 0617a1d Compare October 22, 2026 09:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants