Repository navigation
Conversation
_evaluate_command() read the terminal width from self.prompt_app, which -c and -f never build, so --auto-vertical-output, \x auto or auto_expand in the config failed every statement with "'NoneType' object has no attribute 'output'". A user with auto_expand = True could not use -c or -f at all. Without a prompt the terminal is asked directly, and only when stdout is a terminal: psql's \x auto leaves a pipe or a file with the plain table whatever its width.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--auto-vertical-output,\x autoandauto_expand = Truein the config break-cand-f(4.7.0+):_evaluate_command()reads the terminal width fromself.prompt_app, which those modes never build, so every statement fails with'NoneType' object has no attribute 'output'. A user withauto_expand = Truein the config cannot use-cor-fat all.Without a prompt the terminal is now asked directly, and only when stdout is a terminal: a pipe or a file gets the plain table whatever its width, which is what psql's
\x autodoes.Two tests against a live server; both fail on
mainwith theAttributeErrorabove.test_format_array_output_expandedis red onmainbefore this change (cli-helpers 2.15.2, see #1653).