Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a VEX AIM (REV1, BLE firmware 1.0.0.b0) advertises both Notify and Indicate on its user/system output characteristics. The current preference selects Indicate: authentication succeeds, but the Python console receives zero bytes. A controlled Bleak run forced to indications reproduced the silence; notifications delivered the raw REPL and subsequent commands.
This change prefers Notify when both modes are advertised, while preserving indicate-only support. A regression test covers both modes, each individual mode and neither mode.
It also fixes two Windows connection-lifetime/error paths encountered during the same investigation:
Validation:
cargo test --lockedpasses on Windows (47 active unit tests and five doctests; hardware-dependent radio/test-peripheral tests remain ignored).cargo fmt --all -- --checkpasses. Physical downstream checks with USB disconnected authenticated, ran Python, retrieved a native 640x480 camera JPEG and reconnected for another state read. The latest JPEG capture/download took 7.908 s with a measured 15 ms connection interval; request acceptance and actual negotiated interval were recorded separately. Camera images and credentials remain local.cargo clippy --locked --all-features -- -D warningsalso passes on Windows.Hardware evidence is limited to that Windows/AIM firmware combination. Other peripherals and platforms have not had hardware acceptance for this change.
Downstream CI now passes on Linux x86_64, Windows x86_64, macOS arm64 and macOS x86_64: https://github.com/Tingsters/vex-aim-agent-workshop/actions/runs/39374119191. This covers the combined workshop build, isolated USB/Bluetooth transport tests, protocol validation, the vendored btleplug unit tests and installer checks. This is downstream software/build validation; it does not establish robot hardware acceptance on the other operating systems or replace this upstream repository's own CI/review.