Skip to content

ChooseProjectButton: Use ListStore and bind to git_manager model - #1825

Open
jeremypw wants to merge 3 commits into
masterfrom
jeremypw/projectchooserbutton/liststore-only
Open

jeremypw wants to merge 3 commits into
masterfrom
jeremypw/projectchooserbutton/liststore-only

Conversation

@jeremypw

Copy link
Copy Markdown
Collaborator

Extracted from #1787 losing any changes not strictly required.

@jeremypw
jeremypw requested a review from a team September 28, 2026 17:03
@jeremypw jeremypw added this to the 8.4.1 milestone Sep 28, 2026

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two things, otherwise looks good

private const string PROJECT_TOOLTIP = N_("Active Git Project: %s");
private Gtk.Label label_widget;
private Gtk.ListBox project_listbox;
private Gtk.SearchEntry project_filter;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used?

private Gtk.Label label_widget;
private Gtk.ListBox project_listbox;
private Gtk.SearchEntry project_filter;
private ListStore project_liststore;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is being cached here. Seems like it's only used during bind_model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants