Repository navigation
Add spec_lint, dialyzer and warnings-as-errors CI gates - #1
Merged
Merged
Conversation
lukaszsamson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI workflow (Elixir 1.20.4 / OTP 29): deps.get, compile,
mix format --check-formatted, andmix spec_lint(errors only).Local run: 46 spec clauses checked, 0 errors, 0 warnings. No fixes or ignores needed.
mix testis not run in CI: DAPCodegenTest generates a sibling../dap_codegen_libproject viamix newand fetches deps, and it fails/hangs when that directory already exists.Also:
mix compile --warnings-as-errorsand a cachedmix dialyzer --format githubstep (priv/plts, 0 warnings locally) in the same job.